Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hex.EncodeTostring with ActorID.key in Text and RichText #255

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Oct 5, 2021

What this PR does / why we need it:

Replace hex.EncodeTostring with ActorID.key in Text and RichText.

Before:

Screen Shot 2021-10-05 at 5 26 50 PM

After:

Screen Shot 2021-10-05 at 5 22 00 PM

Which issue(s) this PR fixes:

Address #251

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins requested review from zeikar and a team October 5, 2021 08:32
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #255 (dcb1d1c) into main (dc3b660) will decrease coverage by 0.15%.
The diff coverage is 15.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   49.95%   49.79%   -0.16%     
==========================================
  Files          54       54              
  Lines        4422     4426       +4     
==========================================
- Hits         2209     2204       -5     
- Misses       1996     2005       +9     
  Partials      217      217              
Impacted Files Coverage Δ
client/client.go 11.46% <0.00%> (ø)
pkg/document/json/rich_text.go 51.02% <0.00%> (ø)
pkg/document/json/text.go 42.46% <0.00%> (ø)
pkg/document/time/actor_id.go 55.17% <0.00%> (-6.37%) ⬇️
yorkie/backend/sync/memory/pubsub.go 48.35% <0.00%> (ø)
pkg/document/time/ticket.go 86.04% <50.00%> (-13.96%) ⬇️
pkg/document/json/rga_tree_split.go 73.87% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3b660...dcb1d1c. Read the comment docs.

Copy link
Contributor

@zeikar zeikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hackerwins hackerwins added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 5, 2021
@hackerwins hackerwins merged commit 0e71f1e into main Oct 5, 2021
@hackerwins hackerwins deleted the replace-encodetostring branch October 5, 2021 10:12
hackerwins added a commit that referenced this pull request Oct 21, 2021
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants