Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fmt.Sprintf with strconv #254

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Replace fmt.Sprintf with strconv #254

merged 1 commit into from
Oct 5, 2021

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Oct 5, 2021

What this PR does / why we need it:

Replace fmt.Sprintf with strconv.

Before

Screen Shot 2021-10-05 at 12 04 00 PM

After

Screen Shot 2021-10-05 at 12 05 16 PM

Which issue(s) this PR fixes:

Address #251

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #254 (bc3150f) into main (3a3ee81) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   49.87%   49.95%   +0.07%     
==========================================
  Files          54       54              
  Lines        4417     4422       +5     
==========================================
+ Hits         2203     2209       +6     
+ Misses       1997     1996       -1     
  Partials      217      217              
Impacted Files Coverage Δ
pkg/document/json/rga_tree_split.go 73.87% <100.00%> (+0.45%) ⬆️
pkg/document/time/ticket.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3ee81...bc3150f. Read the comment docs.

Copy link
Contributor

@zeikar zeikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hackerwins hackerwins merged commit dc3b660 into main Oct 5, 2021
@hackerwins hackerwins deleted the replace-sprintf branch October 5, 2021 07:22
jeonjonghyeok pushed a commit to jeonjonghyeok/yorkie that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants