Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a bikehorn esword for the clown #22723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ktlwjec0
Copy link
Contributor

Document the changes in your pull request

Idea is from this: yogstation13/yogstation-2017-#2483

Adds a special esword for clown traitors, 1tc more than a normal one as it's stealthy when concealed.
When concealed it looks and acts like a normal bikehorn except it has esword blocking+fire resistance.
When not concealed, it is pink and creates a fun pink light that surrounds you.
It honks you on-hit, when both concealed and not.
See spriting/testing for images.

Why is this good for the game?

I've been wanting to add this for a while, I think it is quite funny to have an energy sword hidden in a bike horn. If they're going to buy an esword then why not make it a fun one?

Testing

image
image

Spriting

image

🆑 ktlwjec
rscadd: Bike horn energy sword can be bought by clown traitors.
/:cl:

@ktlwjec0 ktlwjec0 requested a review from a team as a code owner October 16, 2024 11:50
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Sprites This PR has spriting changes labels Oct 16, 2024
@SapphicOverload SapphicOverload added the Old Yogs Port Oh yeah we didnt port everything yet label Oct 17, 2024
@SapphicOverload
Copy link
Contributor

The description about how it can block things kinda gives it away

/obj/item/melee/transforming/energy/sword/bikehorn/Initialize(mapload)
. = ..()
AddComponent(/datum/component/squeak, list('sound/items/bikehorn.ogg'=1), 50)
qdel(GetComponent(/datum/component/cleave_attack))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the component and adding it back every time it's toggled off and on, you should add a trait that hides the examine description of the cleave attack and blocking components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am too stupid to figure this out which is why I left it for blocking, if you could help out that'd be great.
I removed the cleave attack since I removed the damage when it's in the bikehorn state, I thought it was a bit silly to leave in.

@AMyriad
Copy link
Contributor

AMyriad commented Oct 21, 2024

The description about how it can block things kinda gives it away

mfw examining item lets you realize its not what it looked like at a glance

@JamieD1
Copy link
Contributor

JamieD1 commented Oct 28, 2024

Honk

@JamieD1
Copy link
Contributor

JamieD1 commented Nov 21, 2024

@SapphicOverload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Old Yogs Port Oh yeah we didnt port everything yet Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants