Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main with v2.7.0 #328

Merged
merged 50 commits into from
Sep 19, 2024
Merged

Update main with v2.7.0 #328

merged 50 commits into from
Sep 19, 2024

Conversation

deribaucourt
Copy link
Member

No description provided.

deribaucourt and others added 30 commits July 19, 2024 17:36
The script fetch:spdx-licenses is now a mandatory step to build the extension.
We no longer track and update the wasm files in our project, related terms on wasm should be updated.
Bumps [mocha](https://github.com/mochajs/mocha) and [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha). These dependencies needed to be updated together.

Updates `mocha` from 10.2.0 to 10.7.0
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v10.2.0...v10.7.0)

Updates `@types/mocha` from 10.0.3 to 10.0.7
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.90.0 to 1.92.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

---
updated-dependencies:
- dependency-name: "@types/vscode"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.90.0 to 1.92.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode)

---
updated-dependencies:
- dependency-name: "@types/vscode"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [vscode-languageserver-textdocument](https://github.com/Microsoft/vscode-languageserver-node/tree/HEAD/textDocument) from 1.0.11 to 1.0.12.
- [Release notes](https://github.com/Microsoft/vscode-languageserver-node/releases)
- [Commits](https://github.com/Microsoft/vscode-languageserver-node/commits/release/textDocument/1.0.12/textDocument)

---
updated-dependencies:
- dependency-name: vscode-languageserver-textdocument
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.28.1 to 2.29.1.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.28.1...v2.29.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Use git ls-remote command to fetch refs or tags instead of cloning the projects first. This script now only takes a few seconds to complete.
The current master branch also outputs the .bb location in the devtool
status output. It broke our parsing which could not detect the
workspaces.

The regex was updated to optionally match the .bb location. But we don't
capture it since we always run a complete scan in the end. This could
be way for future optimizations.
If the user configures a faulty working directory, the error message
was not very clear. This very simple check will show a more clear
message early on.
Sanity tests now require a valid working directory to be provided.
With the fetch script refactoring, we had a regression in the node
package of the CI wich missed these resources.
This command is responsible for executing bitbake command `bitbake -e` and sending the output to the server for
further processing in order to provide necessary language features such as hover definition for conf files.
This commit only handles the command execution and the rest will be done in the following commits.
…ult is not avaiable

This also allows the features such as hover, go to definition to work on conf and bbclass files.
…rd-coding it

The intention is to display the function name in the log messages for quick tracking. When the function name is changed,
the text in the log message needs to change accordingly. Thus, it is better to access it with code instead of hard-coding it
so we don't forget.
Plugin eslint-plugin-import, eslint-plugin-n and eslint-plugin-promise were added at the very beginning of the eslint setup.
But they were never used. eslint-plugin-jest was added along with the jest framework and it was never used either.
.eslintrc.js and .eslintignore are deprecated and the new flat config system is preferred. The CLI also doesn't
support --ext flag with the flat config system.

How the new config is generated:
https://eslint.org/docs/latest/use/configure/migration-guide#migrate-your-config-file
Reference for cli flag changes:
https://eslint.org/docs/latest/use/configure/migration-guide#cli-flag-changes
Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 16.2.0 to 16.6.2.
- [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases)
- [Changelog](https://github.com/eslint-community/eslint-plugin-n/blob/master/CHANGELOG.md)
- [Commits](eslint-community/eslint-plugin-n@16.2.0...16.6.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-n
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot bot and others added 20 commits September 12, 2024 15:56
Bumps [eslint-plugin-promise](https://github.com/eslint-community/eslint-plugin-promise) from 6.1.1 to 6.6.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-promise/releases)
- [Changelog](https://github.com/eslint-community/eslint-plugin-promise/blob/main/CHANGELOG.md)
- [Commits](eslint-community/eslint-plugin-promise@v6.1.1...v6.6.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-promise
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [web-tree-sitter](https://github.com/tree-sitter/tree-sitter) from 0.22.6 to 0.23.0.
- [Release notes](https://github.com/tree-sitter/tree-sitter/releases)
- [Changelog](https://github.com/tree-sitter/tree-sitter/blob/master/CHANGELOG.md)
- [Commits](tree-sitter/tree-sitter@v0.22.6...v0.23.0)

---
updated-dependencies:
- dependency-name: web-tree-sitter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
In CI, eslint is fine.

However, if I run it locally, it tries to cover the project folder and
the server folder symlink in client (already handled in ./server).

I checked that errors in client, integration-tests and server are still
properly detected.
The server is not compiled in client/server anymore.
This is not a regular bitbake command, which have a default timeout
that's 300s. This command should be faster, so 20s is enough.
In the specific case of the BitbakeTerminalProfile, the environment
used was the one defined in the global settings. It did not take
into account the ones defined in the build configurations if defined.
A lot of places in the code were using the global config when they
should be using the buildConfiguration specific one, if available.

ESDK mode not affected because it takes a flat config.
pathToBitbakeFolder not affected because it is in the general section.
Two months ago, a commit was introduced that adds tasks with special
characters which broke our JSON parsing.

Since this variable is not extended, we might miss some tasks, but at
least we keep providing the feature. I could not identify a replacement
variable that would contained the expanded list of tasks.

We would need to run a `bitbake list-tasks` but it would be slower.
This will allow us to track which recipes were marked as skipped by
bitbake.

Skipped recipes are recipes that are not buildable in the current
configuration, but available in the workspace.
We use this variable to determine if the scan result data saved in the
workspace state is up to date. Since this should be modified whenever
the structure of the scan data changes, it makes sense to keep it in the
same file as the scan data structure.

Also added a reminder comment to increment the version number when the
structure changes.
We are going to display these recipes with a description in the
BitbakeRecipesView. It will allow users to see skipped recipes they
would be interested in, and understand why they are skipped.
Now that we keep and track skipped recipe items, we want to know
their source. Adapt the regex to capture the filename and truncate
the skipped reason. It is already captured in the ElementInfo.skipped
from the recipe scan.
This will allow users to know why recipes are not buildable when
they were skipped.

A warning icon and description will clearly present this.

Not much performance impact for recipes array traversal since this
is only done on the hand-selected active recipes.
Even though their shouldn't be many active recipes, we want to avoid
looping multiple times through the list of recipes.
The SCAN_COMPLETE event needed to be reordered so that the data is
passed before computing the view.
@deribaucourt deribaucourt merged commit 7fe5224 into main Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants