Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Reset events on release #25

Closed
ThumbGen opened this issue Dec 24, 2015 · 3 comments
Closed

Suggestion: Reset events on release #25

ThumbGen opened this issue Dec 24, 2015 · 3 comments
Labels

Comments

@ThumbGen
Copy link

Just a small suggestion (reproducible via your demo too) for improving usage of "dir" events:

  • move joystick up => the dir:up event is triggered
  • release
  • move joystick up => the dir:up event is NOT triggered (seems u cache the last status)

Would help a lot getting an event each time the direction changes. Basically after release all "events" should be reset to None or something.

Just an idea

Merry Xmas!

@yoannmoinet
Copy link
Owner

I feel like this is a bug.
It should be reseted.
Somehow, sometimes it's triggered (after at least once).

Thanks for the heads up.
Merry Xmas to you too.

Edit: Oh I see... it's triggered when you start in a new direction. Definitely a bug.

@ThumbGen
Copy link
Author

Thanks for the fix, helps a lot!

PS: Maybe you can update also the "dist" content as many users directly use those files.

@yoannmoinet
Copy link
Owner

Definitely.
Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants