fix: use transform translate for nipple front #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I read the code correctly, I also think |
|
Thanks for this, I'll have a look asap. |
|
Any chance we could revive this PR and make it happen? :) I'm also seeing some significant FPS drop when moving the joystick. |
|
@verekia I've been using this branch in production since I made this PR and it seems stable, you could depend directly on it until @yoannmoinet deals with the pr |
|
Hey sorry about that, thanks for the new ping. |
|
Published in v0.10.0 |
|
Thanks a lot to you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #168, this uses transform: translate instead of setting top/left on the nipple front.
Two notes that might be worth their own issue:
The npm prepare script runs on npm install, and setting NODE_ENV fails on windows. I'd personally prefer cross-env for something like this.
Also, 6 of the tests fail without any of my changes? 6 still fail with them.