Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pump reservoir #88

Open
rgsearley opened this issue Nov 1, 2024 · 2 comments · May be fixed by #89
Open

pump reservoir #88

rgsearley opened this issue Nov 1, 2024 · 2 comments · May be fixed by #89
Assignees
@yo-han
Labels
enhancement New feature or request

Comments

@rgsearley
Copy link

id like to changr rge nightscout reservoir remain, to the reservoir amount and not the IOB

i assume its this line of code
reservoir=rawdata["activeInsulin"]["amount"],

what should it be changed to?
@sedy89
Copy link
Contributor

sedy89 commented Nov 18, 2024

id like to changr rge nightscout reservoir remain, to the reservoir amount and not the IOB

i assume its this line of code
reservoir=rawdata["activeInsulin"]["amount"],

what should it be changed to?

You can change it to rawdata["reservoirRemainingUnits"]

yo-han added a commit that referenced this issue Dec 6, 2024
@yo-han
Fix reservoir amount in Nightscout uploader
5d3e40b 
Related to #88

Change the reservoir amount to use `rawdata["reservoirRemainingUnits"]` instead of `rawdata["activeInsulin"]["amount"]`.

* Modify `custom_components/carelink/nightscout_uploader.py` to update the `reservoir` parameter.
* Update the `__getDeviceStatus` method to reflect this change.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/yo-han/Home-Assistant-Carelink/issues/88?shareId=XXXX-XXXX-XXXX-XXXX).
@yo-han yo-han linked a pull request Dec 6, 2024 that will close this issue
Open
@yo-han
Copy link
Owner

yo-han commented Dec 6, 2024

I made a pull request to fix this issue. I do not use Nightscout myself so maybe @sedy89 can review it before I merge. #89

@yo-han yo-han self-assigned this Dec 6, 2024
@yo-han yo-han added the enhancement New feature or request label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yo-han yo-han

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reservoir amount in Nightscout uploader yo-han/Home-Assistant-Carelink
3 participants
@yo-han @rgsearley @sedy89