Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bonds price history doesnt work #5

Closed
Aks1623 opened this issue May 23, 2022 · 2 comments
Closed

bonds price history doesnt work #5

Aks1623 opened this issue May 23, 2022 · 2 comments

Comments

@Aks1623
Copy link

Aks1623 commented May 23, 2022

firstly Thanks for trying to find a solution around the 429 error , it is the bane of my existence for now .. i am glad i found this package .

the function doesn't work for Bonds

i attach the snapshot below of what the price history function throws vs what investpy api says

Screenshot 2022-05-23 at 10 05 27

@ymyke
Copy link
Owner

ymyke commented May 23, 2022

Thanks for pointing this out. It seems that the bond type is buggy in investpy. I reported it here: alvarobartt/investpy#572

But I made the type work for tessa:

from tessa import price_history
df, currency = price_history("Australia 30Y", "bond")

This will return the prices, albeit with "UNKNOWN" currency, since the currency column is missing in the dataframe that investpy returns.

Also, I'm not sure which and how many bonds work correctly since investpy currently doesn't support the country param in get_bond_historical_data.

...

Love this: "the 429 error , it is the bane of my existence for now" 🤣🤣 That made my day.

@ymyke
Copy link
Owner

ymyke commented May 23, 2022

Update to the latest release v0.3.0 to get the new code. I hope this works for you. Closing this now.

@ymyke ymyke closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants