Fundamental skills philosophy; with skills such as Empty

[ymyke]

Empty is a candidate skill for "A card with Empty will not provide any fire or spirits. This also means the card cannot be sacrificed."

There are at least two basic philosophies to implement such skills:

a) A card with Empty keeps all its stats (esp. has_*) and the code does special handling to check for cards with this skill wherever appropriate (e.g., card placement).

• Could be implemented using properties for all card attributes that take care of taking into account such cases.
• A card always shows its currently relevant states.

b) A card keeps its original stats and adjusts its stats as it gets (and loses, in which case the original stats will be restored) a skill such as Empty.

• That way, the code does not need to identify and handle special cases.
• But it needs to update the states.

b1) Use the state introduced by FightCard for this.

• Simple, already implemented.
• Could use a skill hook that gets called when a FightCard gets created.
• If skills such as Empty play a role in non-fight locations, we'd still need to use the FightCard for that.
• How would cards get displayed inside and outside of fights? In their "Card" or in their "FightCard" state?
• One way to resolve the questions here could be to consider skills "fightskills" that are only applicable in fights and therefore always should the cards in their FightCard state. (If there are other locations, can always do an additional check to see if a skill exists on the card or not.)
• Advantage: We can show the card both in its unskilled and in its skilled state (and offer both views to the user with a keystroke). With option a, this is not possible.

b2) Introduce a new state for this.

• Too complex!

Conclusion

Preference for a ATM.

[ymyke]

→ a (it is also the way Underdog is currently implemented) – (maybe use properties for such cases at some point)