PIP package #93
Replies: 12 comments
-
This repo serves as a research's project, but if it needed surely I can make a pip package. Do you need it for training or for inference? |
Beta Was this translation helpful? Give feedback.
-
Mostly for inference. I was planning to make a Gradio demo, but I can also do that by just cloning the repo. (Might make a PR later if that's ok.) |
Beta Was this translation helpful? Give feedback.
-
Yes, please do so if you can. Thanks for your contribution. |
Beta Was this translation helpful? Give feedback.
-
This will require a restructuring of the files (putting them all in one folder) and may break the demos, so I'll work on it in a fork for now. |
Beta Was this translation helpful? Give feedback.
-
I've got a very hacky fork that should be pip installable here (still need to create |
Beta Was this translation helpful? Give feedback.
-
Thanks for this, and the demo, @fakerybakery Would be nice to have inference.py commited and mainlined. |
Beta Was this translation helpful? Give feedback.
-
Hi @lxe, by I'm going to delete my pip fork because it breaks training, config, etc. Personally, I think it would be better to have an external "wrapper" repository that's pip-installable to keep the training scripts, similar to how VoiceFixer has the VoiceFixer pip installable package and the VoiceFixer main repository with training scripts, etc. |
Beta Was this translation helpful? Give feedback.
-
@yl4579 would you mind adding this to the "todo" list in the README? |
Beta Was this translation helpful? Give feedback.
-
My main concern of this is it could contain phonemizer and change the license of the repo. I use notebook intentionally so it doesn't contain any non-MIT libraries. Even if I add it to TODO it probably wouldn't be a part of this repo anyway. |
Beta Was this translation helpful? Give feedback.
-
OK, please see the other comment about the fork |
Beta Was this translation helpful? Give feedback.
-
I was able to wrangle around the inability to import this in my own package: https://github.com/lxe/tts-server Here's what I needed to do:
I think a lot of this styletts code needs some relative module imports and some other cleanup |
Beta Was this translation helpful? Give feedback.
-
I think I can move this to discussion now, as making a pip package would inevitably ruin the current MIT license status unless we have a good MIT licensed phonemizer alternative. |
Beta Was this translation helpful? Give feedback.
-
Hi, are you planning to allow us to install this via pip by creating a
setup.py
file?Beta Was this translation helpful? Give feedback.
All reactions