Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/redo does not trigger scroll #31

Closed
2 tasks done
krassowski opened this issue Feb 4, 2024 · 0 comments · Fixed by #34
Closed
2 tasks done

Undo/redo does not trigger scroll #31

krassowski opened this issue Feb 4, 2024 · 0 comments · Fixed by #34
Assignees
Labels
bug Something isn't working

Comments

@krassowski
Copy link

Checklist

Describe the bug

Ctrl + z / ctrl + y does not scroll to the place where a change was applied

To Reproduce

  1. Set height or max-height on editor to make it scrollable
  2. Create a document with more lines than fits the viewport
  3. Scroll to the end type something
  4. Scroll to the beginning type press ctrl + z
  5. See no scrolling to the place where change happened

Expected behavior
The changes made by undo manager should result in scrolling the editor to relevant place

Screenshots

y.js bindings for CM6 (does not scroll):
does-not-scroll-on-undo-redo

Native CM6 (scrolls fine):
native-scrolls-ok

Environment Information

  • Chrome 121.0.6167.85
  • Whatever is running on the demo site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants