Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing raster-images causing <image> to fail to render #164

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

yisibl
Copy link
Member

@yisibl yisibl commented Nov 15, 2022

The absence of the raster-images feature causes images in <image href> to fail to render, the generated PNG is always transparent.

This PR also adds relevant test cases to cover this API.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
resvg-js ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 7:31AM (UTC)

@yisibl yisibl force-pushed the add-image-url-test branch from 018b02d to f26d43a Compare November 16, 2022 07:30
@yisibl yisibl changed the title test: add image resolver API test case fix: add raster-image feature back and add test case Nov 16, 2022
@yisibl yisibl changed the title fix: add raster-image feature back and add test case fix: add raster-images feature back and add test case Nov 16, 2022
@yisibl yisibl changed the title fix: add raster-images feature back and add test case fix: missing raster-images causing <image> to fail to render Nov 16, 2022
@yisibl yisibl merged commit 2a78ebd into main Nov 16, 2022
@yisibl yisibl deleted the add-image-url-test branch November 16, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants