-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write Gii JavaScript not to use jQuery #282
Comments
Why need to do this for a tool which used usually in a developer's environment? I see no reason to spend force on this. |
Because we don't want jQuery to be required anywhere. Including development environment not to force people to fetch it from package managemer. |
Make sense, but ... |
Yes, that's an option. |
Twitter Bootstrap requires jQuery - are you going to make Gii also TB-free? |
Twitter Bootstrap does NOT require JQuery by its nature. You can use it without JS part. |
@klimov-paul Sorry, I don't get what you want say by this. Right now TB depends on jQuery (see my previous coment), and I hope you don't want to replace official |
But we thought about removing it for a next major release. |
Bootstrap itself can function wihout a JS, during customization you can disable it. |
Dropping jQuery may happen, but not in v4. Bootstrap v3 was released in 2013, and we still not have stable v4, so it may take some time before getting official jQuery-free Twitter Bootstrap... And using fork may create issues with duplicated dependencies - Gii will use fork, some extension will use official package, and we have 2 bootstraps instead one... |
It may also happen that |
Also note that Gii has a console version, which does not require any CSS/JS dependency. |
This is the matter of demand. Usually developers do not mix Composer and Bower dependencies into a single one, like Yii does. Thus they do not consider this dependency as a problem, since it is easy to bypass. Also it seems that Bootstrap major versions are coming out faster then Yii ones... |
However, the fate of Bootstrap is better to be discussed at There several major JS feature related to Gii web interface:
These are not a trivial matters, implementing them without usage of major JS library will cause a lot of effots. It may actually end in creating our own JS framework... The form-related JS issue should be solved at |
I understand your desire to make core jQuery-free: https://github.com/yiisoft/yii2/wiki/Roadmap#client-side But I don't understand why the next steps is needed for the 2.1 core version (according to «Yii2 Roadmap»):
?! Why?
|
Because there's no sense in releasing framework w/o these two tools. |
Why?.. It's just extensions. For example, I've been using Yii without them for many years. |
These extensions are usually placed in I generally do not see a problem in that development tools require jQuery. It's crazy to complicate the development of development tools with the desire to have super clean jQuery-free code. This is not the core. These are just development tools. |
Well, that's correct. It's not a huge priority. |
If so, then we need to remove these items from the core RoadMap. At least remove them from the requirements for version 2.1... |
Done. |
Something to consider, Gii is a completely stand-alone module, it would be OK if it depends on jQuery, since you won't need it in the frontend or backend of your production server. The debug-toolbar is included in frontend and backend, even if it's just during development - it would be nice if it would be jQuery free. |
Exactly the reason why these issues were created. |
Me too who does not understand why to remove Jquery from Gii. Gii is a separate module with completely own html layout. It does not intersect with user's html layout at all. It may safely use any JS/CSS libraries he wants not affecting any user's application page. The only problem is that in application (in But this can be easily solved by removing Jquery dependency from Gii's composer.json, and bundling Jquery with Gii's src/ instead. Then Gii will use it's own Jquery, not conflicting with user's Jquery in any way. Same thing with bootstrap etc. I do not understand why Yii developers should spent time on developing their very own javascript framework just for Gii, if they can solve this problem in this very simple way, use Jquery and be happy. |
This is a also very important regarding client-side package management, maybe "the" reason to use native npm. |
In 2.1 we plan making core jQuery-free and it would be cool if extensions would follow the same path.
The text was updated successfully, but these errors were encountered: