Add hasChanges to AR

[Auramel]

Hi! I have idea - add method to \yii\db\ActiveRecord. I think it conveniently.

/**
 * @return bool
 */
public function hasChanges(): bool
{
    return sizeof($this->getDirtyAttributes()) > 0;
}

And, maybe, rename dirtyAttributes() to changes() or changedAttributes()?

[samdark]

Sounds good to me.

[rob006]

I would like to remind you that AR is is not a final class but only a base for user models - every new method reserves some name and may make naming things harder for the end user. I'm pretty sure that many people already use hasChanges() for they own purpose and many others would like to do this in future.

[CedricYii]

I would rather avoid to change naming logic, and keep "dirty"'s one.

I would go for BaseActiveRecord::isDirty().

However BaseActiveRecord::isAttributeChanged() should be BaseActiveRecord::isAttributeDirty() to be consistent with markAttributeDirty() and getDirtyAttributes().

[samdark]

@rob006 and @CedricYii both have a point.

[armpogart]

Yep, I'm also for consistent naming and in that case add isDirty won't be a big problem as it's not so common to use isDirty method name in your models. So I'm for renaming isAttributeChanged to isAttributeDirty and adding isDirty. (or it could be vice versa, renaming everything to changed and changes)

If the proposal ok, I can make the PR.

[samdark]

@armpogart please do. Dirty sounds better because @rob006 arguments.