Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change webpack devtool to 'eval' from 'source-map' #829

Merged
merged 2 commits into from
Jun 14, 2021
Merged

change webpack devtool to 'eval' from 'source-map' #829

merged 2 commits into from
Jun 14, 2021

Commits on Jun 10, 2021

  1. change webpack devtool to 'eval' from 'source-map' 

    See here for a comparison of webpack devtool options
https://webpack.js.org/configuration/devtool/

'source-map' is listed as one of the slowest options
for build, and is recommended for production builds
that want high quality source maps.
Changing this to 'eval' shaves off 0.5s from the build time,
while still providing a source map in dev mode.

J=SLAP-1373
TEST=manual

see ~0.5s shaved off the webpack build time
see that I get source maps in dev mode, and can
add a console log to a formatter and clicking on
the console.log's line number will take me to the
correct source line in dev tools
    @oshi97
    oshi97 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    2734675 View commit details
    Browse the repository at this point in the history

  2. revert overlay.html change

    @oshi97
    oshi97 committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    4425410 View commit details
    Browse the repository at this point in the history