Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version in Yew docs to 0.19.3 #2377

Closed
allan2 opened this issue Jan 17, 2022 · 5 comments
Closed

Bump version in Yew docs to 0.19.3 #2377

allan2 opened this issue Jan 17, 2022 · 5 comments

Comments

@allan2
Copy link
Contributor

allan2 commented Jan 17, 2022

Since 0.19.0 through 0.19.2 are yanked, the docs should reflect this.

#2312

@voidpumpkin
Copy link
Member

voidpumpkin commented Jan 19, 2022

@allan2 Thank you for your concern.

I checked the docs, we don't specify patch version anywhere in the docs.
As in its 0.19 not 0.19.0 everywhere.

So when you type in 0.19 in your cargo.toml, rust will automatically select the patch version.

@ranile
Copy link
Member

ranile commented Jan 19, 2022

@voidpumpkin see this

[
"0.19.0",
"0.18.0"
]

The version number is 0.19.0. Changing it now is annoying but we should not add the patch version in the future

@voidpumpkin
Copy link
Member

voidpumpkin commented Jan 19, 2022

@hamza1311 Thanks, indeed my bad.
Reopening because we should change them to only include minor versions

@voidpumpkin voidpumpkin reopened this Jan 19, 2022
@ranile
Copy link
Member

ranile commented Jan 19, 2022

Major and minor versions. We just need to exclude the patch version

@ranile
Copy link
Member

ranile commented Dec 10, 2022

Closing this as 0.20 has superseded it

@ranile ranile closed this as completed Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants