Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batcher): stop closing old sinks during replacements #1587

Open
avilagaston9 opened this issue Dec 6, 2024 · 0 comments
Open

fix(batcher): stop closing old sinks during replacements #1587

avilagaston9 opened this issue Dec 6, 2024 · 0 comments

Comments

@avilagaston9
Copy link
Collaborator

If a replacement of one proof is successful, we close the old sink and replace it with the new one. This doesn't contemplate the case where the user has more proofs in the queue. By closing the old sink, the user will never receive a response if other proofs were submitted.
This can be resolved by simply dropping the old sink without closing it.

Before this fix, we need to refactor our handle_connection function to either read messages within a specified time frame or handle only one message per connection. Otherwise, the socket will remain open until the user closes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant