Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tls in batcher connections #1580

Open
wants to merge 18 commits into
base: testnet
Choose a base branch
from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 4, 2024

Support TLS in batcher connections

Description

Before this PR, the TLS connections where handled by a Caddy in the batcher servers.

Now with this PR, the TLS is handled directly in the batcher.

Notes for testing

As mentioned in the updated guide, you'll need to install mkcert. When running the make batcher_start_local command for the first time, it'll ask for authentication to install a locally generated root certificate. It's only needed for devnet.

You should be able to send and verify proofs normally after that.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 linked an issue Dec 4, 2024 that may be closed by this pull request
@Oppen Oppen marked this pull request as ready for review December 18, 2024 17:15
@Oppen Oppen force-pushed the 1573-feat-support-tls-in-batcher-connections branch 2 times, most recently from 3cd946b to 26abbb6 Compare December 18, 2024 21:15
@Oppen Oppen force-pushed the 1573-feat-support-tls-in-batcher-connections branch from 8e072ed to 02b77ff Compare December 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support TLS in batcher connections
3 participants