Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes names inconsistency #923

Open
fabriciofx opened this issue Dec 31, 2018 · 1 comment
Open

Classes names inconsistency #923

fabriciofx opened this issue Dec 31, 2018 · 1 comment

Comments

@fabriciofx
Copy link
Contributor

@yegor256 @paulodamaso
In takes, we've a class name inconsistency. Let's take as example some Base classes. We've RqFormBase and RqFormBase. On the other hand, we've RqCookies.Base, RqHeaders.Base, RqHref.Base, RqMethod.Base, RqRequestLine.Base. This problem is similar to this one. My suggestion is extract all classes inside interfaces, just like in Cactoos. WDYT?
@0crat
Copy link
Collaborator

0crat commented Dec 31, 2018

@paulodamaso/z please, pay attention to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabriciofx @0crat