Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqLive.java:47-49: Refactor the parse method into... #655

Closed
davvd opened this issue Mar 21, 2016 · 19 comments
Closed

RqLive.java:47-49: Refactor the parse method into... #655

davvd opened this issue Mar 21, 2016 · 19 comments

Comments

@davvd
Copy link

davvd commented Mar 21, 2016

Puzzle 519-af7d4687 in src/main/java/org/takes/rq/RqLive.java:47-49 has to be resolved: Refactor the parse method into a new class. This method is too long and too much if-else statements. Covert this into an IfElseClass.... The puzzle was created by Sebin George on 13-Mar-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Mar 21, 2016

@dalifreire it's yours, please go ahead

@davvd davvd added this to the 1.0 milestone Mar 22, 2016
@davvd
Copy link
Author

davvd commented Mar 22, 2016

@yegor256 since there is no milestone yet I set it to "1.0"

@dalifreire
Copy link
Contributor

@davvd please, assign someone else.

@davvd
Copy link
Author

davvd commented Mar 25, 2016

@davvd please, assign someone else.

@dalifreire deducted 30 from your rating :(

@davvd
Copy link
Author

davvd commented Mar 25, 2016

@davvd please, assign someone else.

@dalifreire right, I will find someone else, no problem

@davvd davvd removed the @dalifreire label Mar 25, 2016
@davvd
Copy link
Author

davvd commented Mar 25, 2016

@essobedo please proceed, it's yours

@essobedo
Copy link
Contributor

@davvd here is my PR #657 please find a reviewer.

@davvd
Copy link
Author

davvd commented Mar 26, 2016

@davvd here is my PR #657 please find a reviewer.

@essobedo OK, sure

@essobedo
Copy link
Contributor

@davvd the PR has been merged, please proceed

@essobedo
Copy link
Contributor

@davvd please

@essobedo
Copy link
Contributor

@davvd I guess that there is a good reason that prevents you to go any further so could you please tell me what it is? Just to allow me to be aware of the entire workflow. Thank you in advance.

@essobedo
Copy link
Contributor

essobedo commented Apr 1, 2016

@davvd ping

@essobedo
Copy link
Contributor

essobedo commented Apr 2, 2016

@davvd please close the ticket

@davvd
Copy link
Author

davvd commented Apr 2, 2016

@yegor256 Thanks, closed

@davvd davvd closed this as completed Apr 2, 2016
@davvd
Copy link
Author

davvd commented Apr 2, 2016

@elenavolokhova please, review this ticket for compliance with our QA rules

@essobedo
Copy link
Contributor

essobedo commented Apr 2, 2016

@yegor256 Thanks, closed

@davvd thanks

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Apr 3, 2016

@davvd Looks good!

@elenavolokhova many thanks

@davvd
Copy link
Author

davvd commented Apr 3, 2016

@essobedo 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 82204435

Much appreciated! 30 mins was added to your account, payment ID 82204449, time spent is 163 hours and 53 mins

+30 to your rating, your total score is +435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants