Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RsWithHeaders.java:55-60: To implement the concatenation and... #268

Closed
davvd opened this issue May 9, 2015 · 13 comments
Closed

RsWithHeaders.java:55-60: To implement the concatenation and... #268

davvd opened this issue May 9, 2015 · 13 comments
Milestone

Comments

@davvd
Copy link

davvd commented May 9, 2015

Puzzle 160-f5eebf68 in src/main/java/org/takes/rs/RsWithHeaders.java:55-60 has to be resolved: To implement the concatenation and transformation with conjunction of Concat class and Transform class to get rid of the use of List.add() in the anonymous Response class head() method. That is, we are going to do something like this: return new Concat(res.head(), new Transform(headers, new Trim()))... The puzzle was created by super132 on 8-May-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented May 9, 2015

@yegor256 attached this issue to milestone "1.0" (let me know if this is wrong)

@davvd davvd added this to the 1.0 milestone May 9, 2015
@davvd
Copy link
Author

davvd commented May 9, 2015

@ekondrashev the task is yours plz proceed

@ekondrashev
Copy link
Contributor

@davvd this task is blocked by #275

@davvd
Copy link
Author

davvd commented May 10, 2015

@davvd this task is blocked by #275

@ekondrashev sure, we'll wait for #275

@davvd
Copy link
Author

davvd commented May 10, 2015

@yegor256 we waited for #275, it is closed already

@davvd
Copy link
Author

davvd commented May 13, 2015

@yegor256 Closing this issue now...

@davvd davvd closed this as completed May 13, 2015
@davvd
Copy link
Author

davvd commented May 13, 2015

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@ekondrashev
According to our quality rules:

Some of ticket messages must mention all pull requests where the problem was actually fixed.

There is no link to related PR in comments. Please fix this issue and try to follow this rule in your tickets in the future.

@ekondrashev
Copy link
Contributor

@elenavolokhova Sorry, but I did not have a chance to ask to close this ticket. David made a decision basing on #275 defect resolution, so I just was "too slow".
But anyway, the PR is #279.

@elenavolokhova
Copy link

@ekondrashev Thank you!

@elenavolokhova
Copy link

@davvd Quality is acceptable.

@davvd
Copy link
Author

davvd commented May 14, 2015

@davvd Quality is acceptable.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@davvd
Copy link
Author

davvd commented May 15, 2015

@ekondrashev just added 10 mins to @elenavolokhova (for QA), payment ID is 57307220. Thanks so much! Your account was topped up for 45 mins (transaction ID is 57307264, the task took 40 hours and 40 mins). m=2440, that's why a bonus here for fast delivery. +45 to your rating, your total score is +91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants