Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkLogged.java:74-79: I expect implementations of Response... #174

Closed
davvd opened this issue Apr 15, 2015 · 16 comments
Closed

TkLogged.java:74-79: I expect implementations of Response... #174

davvd opened this issue Apr 15, 2015 · 16 comments

Comments

@davvd
Copy link

davvd commented Apr 15, 2015

Puzzle 101-0be068b8 in src/main/java/org/takes/facets/slf4j/TkLogged.java:74-79 has to be resolved: I expect implementations of Response and Take interfaces will be able convert itself to a loggable string but they don't have this feature. See details here #101 We will use toConsole() in this way this.target.log("...", this.origin.toConsole(), resp.toConsole, ...)... The puzzle was created by Dmitry Zaystev on 3-Apr-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd davvd added this to the 1.0 milestone Apr 18, 2015
@davvd
Copy link
Author

davvd commented Apr 18, 2015

@yegor256 I set milestone here to 1.0, let me know if it is wrong

@marcuss
Copy link

marcuss commented Apr 20, 2015

If no one disagree, @davvd could you assign this one to me?

@yegor256
Copy link
Owner

@davvd pls assign @M4Solutions to this task

@davvd
Copy link
Author

davvd commented Apr 20, 2015

@davvd pls assign @M4Solutions to this task

@yegor256 done. @M4Solutions the task is yours, please go ahead

@davvd
Copy link
Author

davvd commented May 9, 2015

@M4Solutions you're holding this ticket for 18 days already. If it is not finished (and closed) in the next 24 hours, it will be re-assigned to someone else, see No Obligations principle (this article should help if you're stuck); as a reminder, don't forget to remove the @todo puzzle from the source code; -30 to your rating, your total score is -30

@marcuss
Copy link

marcuss commented May 9, 2015

sorry @davvd I didn't know how to manage the workflow on this, because this ticket is still open since there is another ticket Issues #199 asking for details on how to finish this one, @yegor256 is assigned to that one.

if this ticket should be close meanwhile, please do it.

@marcuss
Copy link

marcuss commented May 10, 2015

@davvd as my understanding this ticket should not be assigned to me, instead should be unassigned, or assigned to @yegor256 until this #199 other issue is solved.

@yegor256
Copy link
Owner

@davvd assign me to this pls

@davvd
Copy link
Author

davvd commented May 10, 2015

@davvd assign me to this pls

@yegor256 right, this task is yours, whoever worked before, please stop right now

@davvd davvd added the bug label May 18, 2015
@davvd
Copy link
Author

davvd commented Nov 7, 2015

@yegor256 The task is closed, thanks everybody

@davvd davvd closed this as completed Nov 7, 2015
@davvd
Copy link
Author

davvd commented Nov 7, 2015

@elenavolokhova please, review this task for compliance with our quality rules

@elenavolokhova
Copy link

@yegor256 Could you please clarify, why this ticket was closed? Was there any solution provided or not? It is not mentioned in any comment.

@yegor256
Copy link
Owner

@elenavolokhova the puzzle just disappeared from the source code. This ticket is definitely bad, we just close it.

@elenavolokhova
Copy link

@yegor256 Thank you!

@elenavolokhova
Copy link

@davvd Quality is bad here.

@elenavolokhova
Copy link

@davvd @yegor256 Will this QA review be paid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants