Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #118

Closed
j-rewerts opened this issue Apr 5, 2019 · 12 comments
Closed

Upgrade deps #118

j-rewerts opened this issue Apr 5, 2019 · 12 comments

Comments

@j-rewerts
Copy link
Member

Upgrade extend to version 3.0.2 or later

@j-rewerts
Copy link
Member Author

We have a higher sev dependancy that must be upgraded.
Screen Shot 2019-05-13 at 4 07 31 PM
Neither impacts our end users, but the tar vulnerability could impact us when we're developing.

@j-rewerts
Copy link
Member Author

@CodyGramlich Would you mind making a PR for this when you're free?

@j-rewerts
Copy link
Member Author

@CodyGramlich Sorry for the late review. Could you upgrade Axios as well?

@j-rewerts
Copy link
Member Author

Some history regarding the exploit. We're currently at high risk of a DOS.

@CodyGramlich
Copy link
Collaborator

Looking into it right now.

@CodyGramlich
Copy link
Collaborator

Axios is a dependency of the @nestjs/common package. The latest version of @nestjs/common is 6.2.4, which has not upgraded axios to 0.19.0 yet. nestjs/nest@c687b5b#diff-e5ee084bbc7db467b9d6ba0fba1beb9fL15

@CodyGramlich
Copy link
Collaborator

nestjs/nest#2311 I think we have to wait until this gets merged and wait for their next release.

@j-rewerts
Copy link
Member Author

@CodyGramlich Can you upgrade Nest to 6.x now? When they cut the minor version, we'll be ready that way.

@CodyGramlich
Copy link
Collaborator

Sure. We have to upgrade elasticsearch as well because @nestjs/elasticsearch is a peer dependency of @nestjs/common.

@j-rewerts
Copy link
Member Author

That is pretty unfortunate. Try upgrading and be sure to test the backend.

@j-rewerts
Copy link
Member Author

I'm worried this could alter our schema.

@j-rewerts
Copy link
Member Author

Closed with #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants