Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL 3.6.0 #345

Closed
visr opened this issue Nov 13, 2022 · 5 comments
Closed

GDAL 3.6.0 #345

visr opened this issue Nov 13, 2022 · 5 comments

Comments

@visr
Copy link
Collaborator

visr commented Nov 13, 2022

See JuliaGeo/GDAL.jl#143.
I saw locally that 9 ArchGDAL tests were failing using that branch, but from a quick glance nothing serious. Though let us know if you want us to hold off merging and tagging that PR.

@yeesian
Copy link
Owner

yeesian commented Nov 14, 2022

I saw locally that 9 ArchGDAL tests were failing using that branch, but from a quick glance nothing serious. Though let us know if you want us to hold off merging and tagging that PR.

Should we upperbound the dependency on GDAL here? In the NEWS, it's written that

Breaking changes: Remove use of compatibility wrappers _GetProjectionRef / _GetGCPProjection / _SetProjection / _SetGCPs (#6186)

So I think this package will need to be updated to remain compatible with GDAL 3.6+.

(Update: oh, those are for "out-of-tree vector drivers", so I don't have a good understanding whether that applies to the usage in this package.)

@yeesian
Copy link
Owner

yeesian commented Nov 14, 2022

Oh to answer the question: no issues with you merging and tagging the PR in GDAL.jl.

@visr
Copy link
Collaborator Author

visr commented Nov 29, 2022

Some more info looking at CI results using GDAL.jl 1.5:

https://github.com/yeesian/ArchGDAL.jl/actions/runs/3570501592/jobs/6001534020

The geotransform and nearblack failures are due to changes in GDAL, I also had to update GDAL.jl tests for that: JuliaGeo/GDAL.jl@736192b

The getfield related failures, I don't know why they are failing on the new GDAL.

@evetion
Copy link
Collaborator

evetion commented Dec 22, 2022

Should we upperbound the dependency on GDAL here? In the NEWS, it's written that

I think we must. We've seen multiple times that upstream releases (not only GDAL, also PROJ for example) introduces changes that break tests or actual production code. You can't prevent that with pinning ArchGDAL.

@evetion
Copy link
Collaborator

evetion commented Dec 22, 2022

The getfield related failures, I don't know why they are failing on the new GDAL.

That would be the bugfix:

  • OGRFeature::FillUnsetWithDefault(): do not set driver-specific default values on unset numeric fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants