-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-1280-464] WIP: yearn.finance IPFS deployment #464
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
AWS_DEFAULT_REGION: 'us-east-1' | ||
DOMAIN_NAME: "${{ endsWith(github.ref, '/master') && 'yearn.finance' || 'b3tools.xyz' }}" | ||
REACT_APP_ETHERSCAN_API_KEY: 'GEQXZDY67RZ4QHNU1A57QVPNDV3RP1RYH4' | ||
REACT_APP_ALCHEMY_API_KEY: 'euSwyu6Yf-VQ3NJ32KHxDhHmTta7OvIe' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keys being public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were taken from .env.example, so pretty much public already. Just have to integrate environments into the pipeline as well, and then could have different secrets for each env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldnt we use the variables from .env file directly? Do we need to have this here on public file duplicated?
Linear reply from Fox Crypto: |
Linear reply from xgambitox: |
@FoxTheSin can we get the infra team to review this? |
Hi @gotzenx, the author of this PR has deleted their account. Can I pick up the task? |
Switches deployment to Github Actions, which includes IPFS build and publish, as well as DNS changes. Fixes #446.
By design, will be deployable from PRs, as well as develop+master branches:
PR builds ->
pr-{number}.yearn.dev
.Develop push ->
yearn.dev
.Master push ->
yearn.finance
.Sample PR available here, which highlights deployment steps and output: https://github.com/B3RX8OIPDHDT3/yearn-finance-v3/pull/2
Sample build available from here: https://pr-2.b3tools.xyz
Issues/considerations:
There are several workarounds for this, probs missing some obvious ones as well:
.env.example
, which will need changing then.