fix: typeset invalid dates errors #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarros
changed the title
alexbarros
force-pushed
the
fix/typeset_invalid_dates_errors
branch
from
3313919 to
11cd49b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1678 +/- ##
===========================================
+ Coverage 90.25% 90.27% +0.01%
===========================================
Files 198 198
Lines 6477 6496 +19
===========================================
+ Hits 5846 5864 +18
- Misses 631 632 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fabclmnt
approved these changes
Dec 4, 2024
portellaa
pushed a commit
that referenced
this pull request
Dec 8, 2024
* fix: ignore invalid dates during conversion * fix: apply type conversion to user defined types * test: add unit test to invalid date type convertion * fix: add invalid dates to variable info * fix(linting): code formatting * test: update unit tests * fix: rename to_datetime method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes conversion errors for DateTime types, when receiving unsupported dates (e.g. '0001-01-01').
With this fix the the invalid dates will be ignored when calculating the metrics that depend on the datetime types, while others (e.g. distinct values) will consider the date without any transformation.
It will also display the amount of invalid values identified
