Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Dark Mode only changes the Header #1653

Open
3 tasks done
alikleit opened this issue Oct 4, 2024 · 1 comment
Open
3 tasks done

Setting Dark Mode only changes the Header #1653

alikleit opened this issue Oct 4, 2024 · 1 comment
Labels
feature request 💬 Requests for new features

Comments

@alikleit
Copy link

alikleit commented Oct 4, 2024

Current Behaviour

dark_mode=True only applies to the header, setting config theme to dark breaks the html

Expected Behaviour

background and components to be dark, with font-color to be white

Data Description

df = pd.DataFrame(np.random.rand(100, 5), columns=["a(°C)", "b", "c", "d", "e"])

Code that reproduces the bug

profile = ProfileReport( df,
                        dark_mode=True,
                        )

# this line breaks the html
profile.config.html.style.theme = "dark"

pandas-profiling version

v4.10.0

Dependencies

[tool.poetry]
name = "ydata-profiling-prototype"
version = "0.1.0"
description = ""
authors = ["AliKleit <[email protected]>"]
readme = "README.md"
package-mode = false

[tool.poetry.dependencies]
python = "~3.11"
cloudpickle = "3.0.0"
betterproto = {extras = ["compiler"], version = "^2.0.0b6", allow-prereleases = true}
blackcellmagic = "^0.0.3"
ruff = "^0.6.1"
ydata-profiling = "^4.10.0"
numpy = "2.0.1"
openpyxl = "^3.1.5"

[tool.poetry.group.dev.dependencies]
ipykernel = "^6.29.5"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

OS

Ubunto (WSL)

Checklist

  • There is not yet another bug report for this issue in the issue tracker
  • The problem is reproducible from this bug report. This guide can help to craft a minimal bug report.
  • The issue has not been resolved by the entries listed under Common Issues.
@fabclmnt
Copy link
Contributor

Hi @alikleit ,

thank you for reporting your issue. Nevertheless, the dark mode does not mean a report with black background is going to be generated.

Dark_mode stands for using the bootstrap 'flatly' theme (https://bootswatch.com/flatly/), which in this case and based upon Ydata-profiling code base, only the headers are expected to change in colors.

The theme dark does not exist. Instead bootstrap themes should be considered - https://docs.profiling.ydata.ai/latest/features/custom_reports/#customizing-the-reports-theme.

I'll assume this is a feature request. Nevertheless we won't be prioritizing it for the time being, unless it gets upvoted by the community.

@fabclmnt fabclmnt added feature request 💬 Requests for new features and removed needs-triage labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 💬 Requests for new features
Projects
None yet
Development

No branches or pull requests

3 participants