Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correction for numpy.NaN deprecating to numpy.nan #1649

Merged

Conversation

joshicola
Copy link
Contributor

Correction for the error:

AttributeError: np.NaNwas removed in the NumPy 2.0 release. Usenp.nan instead.

@fabclmnt fabclmnt changed the title BUG-FIX: Correction for numpy.NaN deprecating to numpy.nan fix: Correction for numpy.NaN deprecating to numpy.nan Sep 17, 2024
@fabclmnt fabclmnt self-requested a review September 17, 2024 13:54
@fabclmnt
Copy link
Contributor

Hi @joshicola ,

thank you for your contribution. When setting a name to the PR make sure to use the conventions adopted in our package fix, feat, docs etc, as this is what is used to correctly calculated the package versions.

Thank you for spotting this issue!

Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fabclmnt fabclmnt linked an issue Oct 15, 2024 that may be closed by this pull request
@fabclmnt fabclmnt removed a link to an issue Oct 15, 2024
@fabclmnt fabclmnt force-pushed the BUG-FIX--numpy-2.0-np.NaN-deprecation branch from 5446af6 to c632b35 Compare October 15, 2024 13:19
@portellaa portellaa merged commit 06524cc into ydataai:develop Oct 15, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants