fix: updated scipy version to allow 1.14.x #1666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabclmnt would you please review this PR? |
fabclmnt
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Hi @ankana2113 ,
thank you for your contribution! Nevertheless, your PR messages do not comply with the expected naming and convention. Can you please update the history of your commits to align with fix: (description) or feat: (description).
|
@fabclmnt would you please check if the changes done are alright? |
fabclmnt
force-pushed
the
upgrade_scipy
branch
from
a005974 to
48b1777
Compare
fabclmnt
force-pushed
the
upgrade_scipy
branch
from
48b1777 to
a61da7b
Compare
|
Hi @ankana2113, I've forced the required change this time. Instead of the previous commit message "updated spicy ..." I've insured the expected naming and convention "fix: updated spicy...". I hope this was an incentive to keep contributing to Ydata-profiling! Thank you 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
requirements.txtto support Scipy versions 1.14.xcloses : #1648