Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeseries_heatmap #1601

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

tpuk0
Copy link
Contributor

@tpuk0 tpuk0 commented Jun 7, 2024

timeseries_heatmap from ydata_profiling.visualisation.plot drops an error, when 'entity_column' is of type str.
The reason for this is that the arguments to pivot_table are passed in the wrong order - see documentation.

Existing unit test does not cover a case where entities are strings, thus the bug was missed.

@tpuk0 tpuk0 changed the title Bugfix: timeseries_heatmap fix: timeseries_heatmap Jun 7, 2024
@fabclmnt fabclmnt requested a review from alexbarros June 7, 2024 17:37
@fabclmnt
Copy link
Contributor

fabclmnt commented Jun 7, 2024

HI @tpuk0 ,

thank you for your contribution! The team will be reviewing your PR shortly :)

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (3d4e482) to head (16e2585).
Report is 76 commits behind head on develop.

Files Patch % Lines
src/ydata_profiling/visualisation/plot.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1601      +/-   ##
===========================================
+ Coverage    90.01%   90.09%   +0.07%     
===========================================
  Files          194      196       +2     
  Lines         6368     6438      +70     
===========================================
+ Hits          5732     5800      +68     
- Misses         636      638       +2     
Flag Coverage Δ
py3.8-ubuntu-22.04-pandas 90.09% <85.71%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexbarros alexbarros merged commit 9946037 into ydataai:develop Jun 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants