fix(utils): use 'urllib.request' instead of 'requests' #1177
Conversation
Codecov ReportBase: 90.44% // Head: 90.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1177 +/- ##
===========================================
+ Coverage 90.44% 90.46% +0.01%
===========================================
Files 181 181
Lines 5516 5514 -2
===========================================
- Hits 4989 4988 -1
+ Misses 527 526 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* chore(actions): add semantic pr validation and only add changelog on new releases (#1168) * fix(utils): use 'urllib.request' instead of 'requests' Co-authored-by: Vasco Ramos <[email protected]>
|
As requests is not used, it should be removed from Also, there are two files to update then: |
|
@aquemy Sorry, haven't take a look at those |
* chore(actions): add semantic pr validation and only add changelog on new releases (#1168) * fix(utils): use 'urllib.request' instead of 'requests' Co-authored-by: Vasco Ramos <[email protected]>
requestsdoesn't seem to handle TLS/SSL pretty well. It returnsForbiddenwhen we try to get a content from an HTTPS URL such ashttps://query1.finance.yahoo.com/v7/finance/download/BABA?period1=1635724800&period2=1667260800&interval=1d&events=history&includeAdjustedClose=true. That's why we should useurllib.requestinstead.On the other hand, I need to remove
raise FileNotFoundError("Could not download resource")asurllib.request.urlopenalready handle that with itsHTTPError.