Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update config files to only calculate 'auto' correlation #1158

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jtook
Copy link
Contributor

@jtook jtook commented Nov 21, 2022

The Auto correlation matrix calculation should be enabled by default, with the other correlation matrices disabled.

The example file for this feature has been updated to show:

  • How to disable the 'auto' correlation matrix calculation.
  • How to update the n_bins setting.
  • How to enable the calculation of other correlation matrices.

@jtook jtook force-pushed the fix/correlation_config branch 2 times, most recently from 3e20a05 to 3c93ed7 Compare November 21, 2022 13:48
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required. Please confirm with @alexbarros regarding the configuration file for the time-series (tsmode).

examples/features/correlation_auto_example.py Outdated Show resolved Hide resolved
examples/features/correlation_auto_example.py Outdated Show resolved Hide resolved
@jtook jtook force-pushed the fix/correlation_config branch from 3c93ed7 to 8b31d48 Compare November 22, 2022 11:13
@jtook jtook force-pushed the fix/correlation_config branch from 8b31d48 to 2b3ef66 Compare November 22, 2022 11:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 90.44% // Head: 90.44% // No change to project coverage 👍

Coverage data is based on head (2b3ef66) compared to base (c508c63).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1158   +/-   ##
========================================
  Coverage    90.44%   90.44%           
========================================
  Files          181      181           
  Lines         5516     5516           
========================================
  Hits          4989     4989           
  Misses         527      527           
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtook jtook requested review from fabclmnt and aquemy November 22, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants