Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typechecking to profile report #1139

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

alexbarros
Copy link
Contributor

closes issue #1134

@alexbarros alexbarros requested review from aquemy and fabclmnt November 9, 2022 12:00
@codecov-commenter
Copy link

Codecov Report

Base: 90.89% // Head: 90.90% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8f2b869) compared to base (acaa171).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8f2b869 differs from pull request most recent head 77e4342. Consider uploading reports for the commit 77e4342 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1139   +/-   ##
========================================
  Coverage    90.89%   90.90%           
========================================
  Files          178      178           
  Lines         5086     5090    +4     
========================================
+ Hits          4623     4627    +4     
  Misses         463      463           
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pandas_profiling/profile_report.py 80.99% <100.00%> (+0.17%) ⬆️
src/pandas_profiling/visualisation/plot.py 86.69% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aquemy
Copy link
Contributor

aquemy commented Nov 9, 2022

Just one comment: did you check that everything is properly annotated in the code?

@alexbarros alexbarros merged commit 2fc4a24 into develop Nov 9, 2022
@alexbarros alexbarros deleted the feat/type_checking branch November 9, 2022 15:38
@aquemy aquemy linked an issue Nov 10, 2022 that may be closed by this pull request
@aquemy
Copy link
Contributor

aquemy commented Nov 10, 2022

@alexbarros it is possible to link a PR directly :)

vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
vascoalramos pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
aquemy pushed a commit that referenced this pull request Nov 22, 2022
* feat: add type checking to profile report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce type-checking
4 participants