Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added filter to locate columns #1115

Merged
merged 9 commits into from
Oct 20, 2022
Merged

feat: added filter to locate columns #1115

merged 9 commits into from
Oct 20, 2022

Conversation

g-kabra
Copy link
Contributor

@g-kabra g-kabra commented Oct 19, 2022

Follow up PR to correct inconsistencies encountered in previous PR for same feature (#1101).

@g-kabra g-kabra mentioned this pull request Oct 19, 2022
Merged
@fabclmnt
Copy link
Contributor

fabclmnt commented Oct 19, 2022 •
edited
Loading

@g-kabra after merging into develop I was able to identify some odd behavior in the filter:

  • For some datasets, the filter was not able to locate the selected variable, which means the variables section would just "disappear" if a column was selected;
  • The sections order was altered - interactions are being shown before the variables section for profiles where the minimal setting is set to False.

@fabclmnt
Copy link
Contributor

fabclmnt commented Oct 19, 2022 •
edited
Loading

Check here the report for the titanic dataset
https://user-images.githubusercontent.com/30911746/196782652-1c20ef9c-e6e4-4aed-838f-df053007a883.mov

@g-kabra
Copy link
Contributor Author

g-kabra commented Oct 19, 2022

I did find one issue in the jQuery function I had setup. Since the names were being converted to lowercase, a match wasn't being found. I have updated that and will be committing. Reviews and suggestions appreciated.

@g-kabra
Copy link
Contributor Author

g-kabra commented Oct 19, 2022

As far as the order of Interaction is concerned, I'll sort it out and commit the same.

@g-kabra
Copy link
Contributor Author

g-kabra commented Oct 19, 2022

These two issues are solved. Sorry I had overlooked these in a hurry.

@aquemy
Copy link
Contributor

aquemy commented Oct 20, 2022

I checked the code from @g-kabra locally directly from his fork and it works for Titanic now.

In general, the position of the select is a bit awkward because it breaks the HTML border, but this is a cosmetic thing we might fix later.

@aquemy aquemy self-requested a review October 20, 2022 08:08
@aquemy aquemy merged commit 7885d12 into ydataai:develop Oct 20, 2022
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
@g-kabra @akx @vascoalramos
feat: added filter to locate columns (#1115)
4919cd3 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
@g-kabra @akx @portellaa
feat: added filter to locate columns (#1115)
6871082 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
@g-kabra @akx @vascoalramos
feat: added filter to locate columns (#1115)
7a4d119 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
@g-kabra @akx @portellaa
feat: added filter to locate columns (#1115)
c2f817d 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
@g-kabra @akx @portellaa
feat: added filter to locate columns (#1115)
970e4f9 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
@g-kabra @akx @vascoalramos
feat: added filter to locate columns (#1115)
53b10f8 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
@g-kabra @akx @vascoalramos
feat: added filter to locate columns (#1115)
af3be57 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
@g-kabra @akx @vascoalramos
feat: added filter to locate columns (#1115)
254dbc8 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
chanedwin pushed a commit that referenced this pull request Oct 30, 2022
@g-kabra @akx @chanedwin
feat: added filter to locate columns (#1115)
2562c93 
* feat: added filter to locate columns

* Update .pre-commit-config.yaml

* Apply suggestions from code review

Co-authored-by: Aarni Koskela <[email protected]>

* feat: added support for variable search in ipywidgets

* fix: variables not being filtered according to dropdown

* fix: variables not being filtered according to dropdown

* fix: fixed order of sections

Co-authored-by: Aarni Koskela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquemy aquemy aquemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-kabra @fabclmnt @aquemy