Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correlation auto passing extra parameters #1114

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

alexbarros
Copy link
Contributor

@alexbarros alexbarros commented Oct 19, 2022

Fix "Auto" correlation requiring extra configuration parameter n_bins which was already available through settings.

@alexbarros alexbarros requested review from aquemy and jtook October 19, 2022 17:00
@codecov-commenter
Copy link

Codecov Report

Base: 90.98% // Head: 90.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e741e25) compared to base (e0a6c56).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1114   +/-   ##
========================================
  Coverage    90.98%   90.98%           
========================================
  Files          177      179    +2     
  Lines         5057     5082   +25     
========================================
+ Hits          4601     4624   +23     
- Misses         456      458    +2     
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pandas_profiling/model/correlations.py 87.87% <ø> (ø)
...ndas_profiling/model/pandas/correlations_pandas.py 98.78% <100.00%> (ø)
...das_profiling/report/presentation/core/__init__.py 100.00% <0.00%> (ø)
...profiling/report/presentation/flavours/flavours.py 71.42% <0.00%> (ø)
...ling/report/presentation/flavours/html/__init__.py 100.00% <0.00%> (ø)
...das_profiling/report/presentation/core/dropdown.py 87.50% <0.00%> (ø)
...ling/report/presentation/flavours/html/dropdown.py 100.00% <0.00%> (ø)
src/pandas_profiling/report/structure/report.py 94.18% <0.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aquemy aquemy merged commit a60dd8b into develop Oct 20, 2022
@aquemy aquemy deleted the fix/correlation_bins branch October 20, 2022 09:02
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
portellaa pushed a commit that referenced this pull request Oct 20, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
chanedwin pushed a commit that referenced this pull request Oct 30, 2022
* fix: correlation `auto` passing extra parameters

* fix: Remove debugger trace

Co-authored-by: Alexandre Quemy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants