From fbbed11a0fdbf84b346e3f9fd3f8d4b22bf26de6 Mon Sep 17 00:00:00 2001
From: jennypavlova <dzheni.pavlova@elastic.co>
Date: Fri, 30 Aug 2024 11:26:18 +0200
Subject: [PATCH] [Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs
 Metadata Tab should render metadata tab, add and remove filter (#191745)

---
 .../tabs/metadata/add_metadata_filter_button.tsx              | 2 +-
 x-pack/test/functional/page_objects/asset_details.ts          | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx
index f1e0b9073c03..49dfd3d42d5c 100644
--- a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx
+++ b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx
@@ -90,7 +90,7 @@ export const AddMetadataFilterButton = ({ item }: AddMetadataFilterButtonProps)
   }
 
   return (
-    <span>
+    <span data-test-subj={`infraAssetDetailsMetadataField.${item.name}`}>
       <EuiToolTip
         content={i18n.translate('xpack.infra.metadataEmbeddable.setFilterByValueTooltip', {
           defaultMessage: 'Filter by value',
diff --git a/x-pack/test/functional/page_objects/asset_details.ts b/x-pack/test/functional/page_objects/asset_details.ts
index 95a7819fb11a..7ce90d213d23 100644
--- a/x-pack/test/functional/page_objects/asset_details.ts
+++ b/x-pack/test/functional/page_objects/asset_details.ts
@@ -180,7 +180,9 @@ export function AssetDetailsProvider({ getService }: FtrProviderContext) {
     },
 
     async clickAddMetadataFilter() {
-      return testSubjects.click('infraAssetDetailsMetadataAddFilterButton');
+      // Make this selector tied to the field to avoid flakiness
+      // https://github.com/elastic/kibana/issues/191565
+      return testSubjects.click('infraAssetDetailsMetadataField.host.name');
     },
 
     async clickRemoveMetadataFilter() {