Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Rust completer to Rust Language Server #1105

Closed
Saldivarcher opened this issue Sep 18, 2018 · 15 comments · Fixed by #1224
Closed

Migrate Rust completer to Rust Language Server #1105

Saldivarcher opened this issue Sep 18, 2018 · 15 comments · Fixed by #1224

Comments

@Saldivarcher
Copy link

So it seems that racerd, has stalled and hasn't been updated in a year. Were there plans to move to a different rust completion server?

@puremourning
Copy link
Member

Such as?

@bstaletic
Copy link
Collaborator

Last I heard RLS was in a fairly good shape. As in Rust Language Server.

@Saldivarcher
Copy link
Author

Yeah I think RLS would be nice, it seems like it's heavily used and updated regularly.

@puremourning
Copy link
Member

Do you have specific issues that it would address?

@bstaletic
Copy link
Collaborator

@puremourning We already have a couple unresolved rust related issues that might go away with RLS. It might be worth a try.

@puremourning
Copy link
Member

Fair enough. As always provided there is a benefit and no regression and a completely free migration path... :)

Then again I don’t Rust so PRs welcome?

@micbou
Copy link
Collaborator

micbou commented Sep 18, 2018

There is a rough implementation in that branch. If people are interested, I may polish it and submit a PR.

@Saldivarcher
Copy link
Author

Oh awesome @micbou 😎, if you need any help let me know and I'll try to find some time to help.
@puremourning a bunch of small things like: auto completion on types from extern blocks.

@micbou micbou changed the title Any plans to migrate to a different rust completion server? Migrate Rust completer to RLS Sep 30, 2018
@micbou micbou changed the title Migrate Rust completer to RLS Migrate Rust completer to Rust Language Server Sep 30, 2018
@Valloric
Copy link
Member

Valloric commented Oct 6, 2018

We'll eventually need to migrate to RLS since racer is deadish. Also, RLS is powered by racer internally (for the initial RLS implementation).

@jwilm Thoughts?

@bstaletic
Copy link
Collaborator

@micbou Says there's not too much work left to polish his branch enough for migration.

@jwilm
Copy link
Contributor

jwilm commented Oct 7, 2018

RLS capabilities are a super set of Racer's; there's no technical reasons ycmd shouldn't use RLS at this point. There may be some other benefits like eliminating a Rust build step in ycmd in favor of "make sure rls is installed on your system". I believe this comes as a component with rustup today.

@bstaletic
Copy link
Collaborator

Because of rust-lang/rls#641, I'd really prefer if we were to stick to installing RLS in third_party.

@puremourning
Copy link
Member

We are currently working on significantly reducing the overhead in adding new LSP based completers.

When this is complete we will review which servers offer value and stability. We'll keep this in mind.

@Valloric
Copy link
Member

While RLS has its problems, it's the obvious next step for our Rust integration.

@puremourning I love that we're making integrating LSP completers easier! Great work and thank you! :) This will pay off a lot going forward since lots of semantic engines are moving towards implementing the LSP spec.

@bstaletic
Copy link
Collaborator

The RLS PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants