New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix unstable `help` test by locale on localhost #390

Merged

ybiquitous merged 1 commit into master from fix-unstable-locale-on-localhost

May 6, 2019

Owner

ybiquitous commented May 6, 2019

The yargs package depends on the os-locale package to guess the locale.
The os-locale package prioritizes LC_ALL over LANG.

See below:


          test: fix unstable help test by locale on localhost

37905a3

The `yargs` package depends on the `os-locale` package to guess the locale.
The `os-locale` package prioritizes `LC_ALL` over `LANG`.

See below:
- https://github.com/yargs/yargs/blob/51876e69c71e9861fb09847530eeaec9be534f5f/yargs.js#L1184
- https://github.com/sindresorhus/os-locale/blob/22e9f2e66e1493ffda58c9ed8f936f554bccb76f/index.js#L10

ybiquitous merged commit 0716e88 into master

ybiquitous deleted the fix-unstable-locale-on-localhost branch

May 6, 2019 05:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet