Fix regexp stack overflow #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run this in some project dirs I get the following error: long string-length:4573 long string-length:176 long string-length:152007 error in process filter: if: Stack overflow in regexp matcher error in process filter: Stack overflow in regexp matcher long string-length:117095 error in process filter: if: Stack overflow in regexp matcher error in process filter: Stack overflow in regexp matcher long string-length:177532 error in process filter: if: Stack overflow in regexp matcher error in process filter: Stack overflow in regexp matcher This is usually because a match has hit a xml file with no newlines. As a simple hack I truncate the string to (window-width) to avoid this problem.
|
@yasuyk is there an easy way to plumb a test for helm-git-grep-filtered-candidate-transformer-file-line-1 into the tests? I'm sorry I'm not very familiar with ert. |
|
@yasuyk ping? |
|
@stsquad Thank you for PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run this in some project dirs I get the following error:
long string-length:4573
long string-length:176
long string-length:152007
error in process filter: if: Stack overflow in regexp matcher
error in process filter: Stack overflow in regexp matcher
long string-length:117095
error in process filter: if: Stack overflow in regexp matcher
error in process filter: Stack overflow in regexp matcher
long string-length:177532
error in process filter: if: Stack overflow in regexp matcher
error in process filter: Stack overflow in regexp matcher
This is usually because a match has hit a xml file with no newlines.
As a simple hack I truncate the string to (window-width) to avoid this
problem.