Use --null to disambiguate numeric filenames #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opening files from results with filenames such as "1-2-3".
|
@CyberShadow Thank you for your contribution! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opening files from results with filenames such as "1-2-3".
Unfortunately the output of
git grep --nulldoesn't distinguish between matching and context lines, so that information is lost.An alternative would be to use
--colorand specifycolor.grep.*explicitly on the command-line, though that is potentially more fragile and doesn't provide perfect escaping (a file name may contain an ANSI color sequence on POSIX).I would like to add a test for this, however there doesn't appear to be any tests which actually invoke
git grep, so the only option would be to test parsing of simulatedgitoutput.