Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower components not installed automatically from bower.json? #864

Closed
alextreppass opened this issue Oct 12, 2016 · 6 comments
Closed

bower components not installed automatically from bower.json? #864

alextreppass opened this issue Oct 12, 2016 · 6 comments

Comments

@alextreppass
Copy link

alextreppass commented Oct 12, 2016

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
I have a bower.json in the root directory of a project alongside package.json.

The bower.json contents are:

{
  "name": "my-project-name",
  "version": "0.0.0",
  "appPath": "src",
  "resolutions": {
    "angular": "^1.4.8"
  },
  "dependencies": {
    "angular-material": "1.0.3-master-0918596",
    "angular-ui-map": "~0.5.0",
    "angular-tour-no-jQuery": "~0.2.6",
    "ngclipboard": "^1.1.0"
  }
}

Should Bower support work automatically?

(The package.json has a postinstall script that runs bower install. I've seen pre/post-install hooks don't currently get run as per #853, but yarn says it supports bower itself so...)

If the current behavior is a bug, please provide the steps to reproduce.
rm -rf node_modules bower_components

run yarn.

node_modules are populated but bower_components are not.

What is the expected behavior?
yarn reads the bower.json and populates the bower_components folder with bower dependencies.

yarn should also track the bower components in its yarn.lock file (related: #846)

Please mention your node.js, yarn and operating system version.
node 6.2.2
yarn 0.15.1 (installed globally with npm)
bower 1.7.9 (installed globally with npm)
OSX El Capitan

@ankon
Copy link

ankon commented Oct 12, 2016

Note here: if yarn were to process bower.json, it would be very important for us if it would also honor the configuration file .bowerrc, at least the "directory" entry there.

@sb8244
Copy link

sb8244 commented Oct 12, 2016

Further on this:

I have a setup with node_modules and bower_components. Upon deleting the node_modules directory (but leaving bower_components) and running yarn, I get an empty bower_components directory.

@alextreppass
Copy link
Author

@sb8244 you may want #616 for the nixing of bower_components contents

@RustyToms
Copy link
Contributor

This is a duplicate of #665

@omnisite
Copy link

If you add the following to package.json, bower install will be called and it works. It is a workaround though:

"scripts": { "postinstall": "bower install" }

@wyze
Copy link
Member

wyze commented Oct 26, 2016

Bower support has been dropped in #1441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants