Bug: issue with postinstall scripts in git-hooks package

[rjmunro]

Using the following package.json:

{
  "name": "yarn-postinstall-test",
  "version": "1.0.0",
  "description": "Test yarn postinstall functionality",
  "main": "index.js",
  "author": "Jamie Munro ([email protected])",
  "license": "MIT",
  "dependencies": {
    "git-hooks": "1.1.6"
  }
}

and running yarn, I get:

sh: git-hooks: command not found
    at SpawnError (/Users/rjmunro/.nvm/versions/node/v4.4.4/lib/node_modules/yarnpkg/lib-legacy/errors.js:18:1)
    at ChildProcess.<anonymous> (/Users/rjmunro/.nvm/versions/node/v4.4.4/lib/node_modules/yarnpkg/lib-legacy/util/child.js:114:15)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:827:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:477:12)

I guess yarn is running git-hook's postinstall too early in the process, or without node_modules/.bin added to the PATH environment variable.

On second run, I don't get the error, but the command doesn't seem to get executed. I have to run node_modules/.bin/git-hooks manually.

[glebmachine]

+1

[rjmunro]

@glebmachine Please use the "add reaction" icon at the top right of the bug description to add your +1 (which should be written 👍) - that way it will be counted on the list of bugs when you sort them by reaction counts, e.g. https://github.com/yarnpkg/yarn/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

[glebmachine]

@rjmunro got it, thanks)

[rjmunro]

After upgrading yarn to 0.16.0, I now get the following output:

error /Users/rjmunro/projects/application-server/node_modules/git-hooks: Command failed.
Exit code: 127
Command: sh
Arguments: -c git-hooks --install
Directory: /Users/ubuntu/test/node_modules/git-hooks
Output:
sh: git-hooks: command not found
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

[Edit: it's the same error, but it has hidden the traceback and given me information about the arguments is tried to use etc.]

[glebmachine]

This error was before, nothing changed)

[glebmachine]

Still experience error:

yarn add git-hooks
yarn add v0.16.1
warning [email protected]: "dependencies" has dependency "angular-slick-carousel" with range "^3.1.7" that collides with a dependency in "devDependencies" of the same name with version "3.1.7"
warning [email protected]: "dependencies" has dependency "scrollmagic" with range "^2.0.5" that collides with a dependency in "devDependencies" of the same name with version "2.0.5"
warning [email protected]: "dependencies" has dependency "slick-carousel" with range "^1.6.0" that collides with a dependency in "devDependencies" of the same name with version "1.6.0"
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
⠁ 
⠁ 
⠁ 
⠁ 
error ..../node_modules/git-hooks: Command failed.
Exit code: 127
Command: sh
Arguments: -c git-hooks --install
Directory: ..../node_modules/git-hooks
Output:
sh: git-hooks: command not found
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

[DanielZlotin]

maybe related to #760 #1210 ?

[sebmck]

Fixed via #1210.