Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn add fails with scoped packages #3736

Closed
gergelyke opened this issue Jun 27, 2017 · 5 comments
Closed

Yarn add fails with scoped packages #3736

gergelyke opened this issue Jun 27, 2017 · 5 comments
Labels

Comments

@gergelyke
Copy link

Steps to reproduce

yarn add @risingstack/trace

It fails with:

[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
error Couldn't find a package.json file in "/Users/gergelyke/Development/risingstack/trace/yarn-test/node_modules/@risingstack/event-loop-stats/node_modules/node-pre-gyp"

Test environment

Node.js 8.1.2
Yarn 0.24.5
OSX Sierra

@ghost
Copy link

ghost commented Jun 28, 2017

Simplifying the problem, yarn add node-pre-gyp results in the dependency coming down without a package.json file and an unexpected, empty node_modules directory inside the installed package.

@ghost
Copy link

ghost commented Jun 28, 2017

@gergelyke Thanks for open issues and cross-linking them. I'm seeing lots of upvotes already on the trace package. Have you been able to do any additional debugging?

Note to triage: Issue replicated under [email protected] as well.

@bestander
Copy link
Member

Is it because event-loop-stats has a bundledDependency without a package.json?

@bestander
Copy link
Member

Can repro this with

yarn add @risingstack/event-loop-stats

@bestander
Copy link
Member

Merging into #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants