Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set version-tag-prefix to empty string #2856

Closed
FissionCat opened this issue Mar 7, 2017 · 5 comments
Closed

Cannot set version-tag-prefix to empty string #2856

FissionCat opened this issue Mar 7, 2017 · 5 comments

Comments

@FissionCat
Copy link

Do you want to request a feature or report a bug? bug

What is the current behavior?

$ yarn config set version-tag-prefix ''
yarn config v0.21.3
success Set "version-tag-prefix" to true.
✨  Done in 0.04s.

When running yarn version, this then adds a tag of the form true<version>.

If the current behavior is a bug, please provide the steps to reproduce.

Run yarn config set version-tag-prefix '' as above.

I've tried yarn config set version-tag-prefix false and yarn config set version-tag-prefix null to see if they produce the desired result, but they gave me tags of the form false<version> and null<version>, respectively (not surprised there, just being thorough).

I have also tried running yarn config delete version-tag-prefix, but that just sets its value back to the default, 'v'.

What is the expected behavior?
yarn config set version-tag-prefix '' should set the value of version-tag-prefix to ''

Please mention your node.js, yarn and operating system version.
node: v6.7.0
yarn: v0.21.3
OS: macOS Sierra (10.12.3)

@arcanis
Copy link
Member

arcanis commented Apr 28, 2017

Should be fixed in master (#3018)

@arcanis arcanis closed this as completed Apr 28, 2017
@FissionCat
Copy link
Author

@arcanis I've tested with 0.23.3, it's still failing on my machine:

$ yarn config set version-tag-prefix ''
yarn config v0.23.3
success Set "version-tag-prefix" to true.
✨  Done in 0.04s.
$ yarn config list
yarn config v0.23.3
info yarn config
{ 'version-tag-prefix': true,
...etc.

@arcanis
Copy link
Member

arcanis commented May 2, 2017

The fix will be released along with the 0.24 build, which will be published somewhere this week.

@FissionCat
Copy link
Author

Ah, okay - my bad, I assumed the fix had been released. Thanks for letting me know!

@retog
Copy link

retog commented Mar 19, 2018

Still having this issue. First experienced it with yarn v1.3.2 now updated to v1.5.1 but the problem is still there, exactly as described by @FissionCat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants