Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm compat] bundledDependencies in package.json is not considered optional as by npm #2546

Closed
bestander opened this issue Jan 24, 2017 · 1 comment

Comments

@bestander
Copy link
Member

bestander commented Jan 24, 2017

Do you want to request a feature or report a bug?
feature

What is the current behavior?

yarn add [email protected]
yarn add v0.18.1
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
error Couldn't find a package.json file in "/Users/bestander/work/temp/tap/node_modules/tap/node_modules/tap-consumer"
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

What is the expected behavior?

Npm@3 installs tap-consumer from npm even though it is not in dependencies and is missing from the package as described in bundledDependencies

Users/bestander/work/temp/tap
└─┬ [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ ├── [email protected]
│ ├── [email protected]
│ └── [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│ └─┬ [email protected]
│ ├── [email protected]
│ └── [email protected]
├── [email protected]
├─┬ [email protected]
│ ├── [email protected]
│ ├─┬ [email protected]
│ │ └── [email protected]
│ └── [email protected]
└── [email protected]

This is clearly an error in package but we might consider backporting the bug

Please mention your node.js, yarn and operating system version.
Node 6
Yarn 0.18+
Mac OS / Linux

@bestander bestander changed the title [npm compat] bundledDependencies in package.json is considered optional by npm [npm compat] bundledDependencies in package.json is not considered optional as by npm Jan 24, 2017
@TrustNik
Copy link

Linked #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants