[0.17.0] Regression: Doesn't run install script

[STRML]

After upgrading to 0.17.0, I noticed install scripts are not running.

To test, run:

yarn add nodent-runtime
ls ./node_modules/nodent-runtime/dist

There should be an index.js built there, but there is not.

The package.json for that package:

  "scripts": {
    "test": "node tests",
    "install": "node build.js"
  },

This does not happen in 0.16.1.

[wyze]

I just tested this on latest master and it does generate a ./node_modules/nodent-runtime/dist/index.js file.

[wyze]

I tested this on 0.17.0 and the scripts run fine for me. What node version an OS are you on?

v6.7.0 on macOS Sierra for me.

[STRML]

OSX El Capitan, here's the output:

~/g/forks $ mkdir footest
~/g/forks $ cd footest
~/g/f/footest $ yarn add nodent-runtime
yarn add v0.17.2
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ [email protected]
✨  Done in 1.11s.
~/g/f/footest $ tree
.
├── node_modules
│   └── nodent-runtime
│       ├── LICENSE
│       ├── build.js
│       ├── dist
│       │   └── README.md
│       ├── package.json
│       ├── runtime.js
│       ├── tests
│       │   └── index.js
│       ├── thenable.js
│       ├── thenableFactory.js
│       └── zousan.js
├── package.json
└── yarn.lock

4 directories, 11 files
~/g/f/footest $ node --version
v6.9.1
~/g/f/footest $

[hpurmann]

macOS Sierra 10.12.1, node 6.9.1

Can't reproduce neither with current master (4ce67f3) nor with 0.17.0.

@STRML or @kevinzwhuang can you provide a Dockerfile to reproduce?

[bestander]

Can't reproduce this on latest either

[bestander]

@STRML, can you clear caches?

[STRML]

Clearing caches doesn't help - but it appears my npmrc is the culprit.

Moving it out fixed the issue. What's perplexing is that when moving back in, the issue remained fixed.

The contents of my ~/.npmrc:

_auth=xxxx
init.author.name=My Name
[email protected]
init.author.url=http://strml.net/
always-auth=true
spin=false
loglevel=http
@private:registry=http://xx.xx.xx.xx:4873
//xx.xx.xx.xx:4873/:_password=xxxxxx
//xx.xx.xx.xx:4873/:username=myusername
//xx.xx.xx.xx:4873/:[email protected]
//registry.npmjs.org/:_password=xxxxxx
//registry.npmjs.org/:username=myusername
//registry.npmjs.org/:[email protected]
//xx.xx.xx.xx:4873/:always-auth=true
//registry.npmjs.org/:always-auth=true
registry=https://registry.npmjs.org/
[email protected]
progress=false

I'm working on a Dockerfile to see if I can reproduce it.

[STRML]

After moving my ~/.npmrc in and out, I'm not able to reproduce this. Something pretty bizarre there, like a run of yarn without an .npmrc present reset something internal which fixed the bug.

If anyone else is experiencing this, working off https://github.com/STRML/yarn-install-lifecycle-bug might help you get to the bottom of it.

[markstos]

I recommend closing this issue since the issue can't be reproduced. If someone can reproduce the issue, it can be re-opened.

[kevinzwhuang]

@bestander This seems to have been fixed as of v0.17.4 - Also tested for the similar node-sass case in #1832: #1832 (comment)