Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize version conflict strategy #1150

Closed
otakustay opened this issue Oct 17, 2016 · 2 comments
Closed

Optimize version conflict strategy #1150

otakustay opened this issue Oct 17, 2016 · 2 comments

Comments

@otakustay
Copy link

Do you want to request a feature or report a bug?

feature

What is the current behavior?

Suppose we have dependencies below:

after yarn install in main module, the node_modules tree could be:

node_modules
├── a
│   └── node_modules
│       └── underscore <-- 1.7.x
├── b
│   └── node_modules
│       └── underscore <-- 1.7.x
├── c
└── underscore <-- 1.5.x

What is the expected behavior?

It's not an optimized result since [email protected] is used more times than 1.5.x, it could be better to place 1.7.x under the top node_modules directory and only put a sub 1.5.x in c/node_modules

In frontend environment we really care about file sizes, but --flat flag may introduce compatibility issues, so to optimize the version conflict strategy can provide considerable benifits

Please mention your node.js, yarn and operating system version.

  • Node: v6.8.0
  • yarn: v0.15.1
  • OS: macOS 10.12
@ghost
Copy link

ghost commented Feb 14, 2017

@otakustay and @Daniel15, I believe this issue will be mitigated, if not entirely resolved by #2676

@gsklee
Copy link
Contributor

gsklee commented Jun 21, 2017

@destroyerofbuilds indeed, thanks!

@gsklee gsklee closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants