-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings option for explain peer-requirements #6467
base: master
Are you sure you want to change the base?
Conversation
packages/plugin-essentials/sources/commands/explain/peerRequirements.ts
Outdated
Show resolved
Hide resolved
Some notes:
|
As I have said in #6329 (comment), the problem with this approach is that the flag is simply ignored in I don't mind it as a short-term solution but I think we still need to figure out a long-term solution |
Thanks for the reference to #6329, I've updated the issue I opened to point there. While I do agree showing the unmet peer requirements would be more desirable it would be a breaqking change. I think adding this flag for the meantime makes sense as long as we can work on the solution for (potential) Yarn v5. |
What's the problem this PR addresses?
Adresses #6329.
...
How did you fix it?
Add an option called
--warnings
and changed the behaviour ofexplainPeerRequirements
to not print met peer requirements when the option is enabled,...
Checklist