Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Docusaurus e2e test #3863

Merged
merged 1 commit into from
Jan 5, 2022
Merged

ci: add Docusaurus e2e test #3863

merged 1 commit into from
Jan 5, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Dec 11, 2021

What's the problem this PR addresses?

We don't have an e2e test for Docusaurus

Depends on

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@Josh-Cena
Copy link

beta.14 has been published with the compat problems addressed. Maybe we can test again? (There's also facebook/docusaurus#6157 and maybe the TS check still won't work until next version)

@merceyz
Copy link
Member Author

merceyz commented Dec 22, 2021

Thanks for the update 👍. I re-ran the test and it passes now. I noticed the TypeScript issues as well but left it alone for now, since this e2e test doesn't run it, it doesn't block this PR.

@merceyz merceyz force-pushed the merceyz/ci/e2e-docusaurus branch 2 times, most recently from 171dfa2 to 755df92 Compare January 3, 2022 23:58
@merceyz merceyz force-pushed the merceyz/ci/e2e-docusaurus branch from 755df92 to 289bc5c Compare January 3, 2022 23:59
@merceyz merceyz marked this pull request as ready for review January 5, 2022 12:19
@merceyz merceyz requested a review from arcanis as a code owner January 5, 2022 12:19
@arcanis arcanis merged commit 28781c1 into master Jan 5, 2022
@arcanis arcanis deleted the merceyz/ci/e2e-docusaurus branch January 5, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants