Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compat): update extensions list #3152

Merged
merged 6 commits into from
Jul 22, 2021
Merged

chore(compat): update extensions list #3152

merged 6 commits into from
Jul 22, 2021

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 21, 2021

What's the problem this PR addresses?

Updates the extensions list to include

Closes #3150

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit b4bacc4 into master Jul 22, 2021
@arcanis arcanis deleted the merceyz/chore/compat branch July 22, 2021 15:23
@chenyulun
Copy link

Please withdraw your this this change, [email protected] supports @vue/compiler-sfc@^2.7.0.

@chenyulun
Copy link

packages/yarnpkg-extensions/sources/index.ts

[`vue-loader@<=16.3.3`, {
    peerDependencies: {
-    '@vue/compiler-sfc': `^3.0.8`,
+      '@vue/compiler-sfc': `^2.7.0 || ^3.0.8`,
      webpack: `^4.1.0 || ^5.0.0-0`,
    },
    peerDependenciesMeta: {
      '@vue/compiler-sfc': optionalPeerDep,
    },
  }]

@merceyz
Copy link
Member Author

merceyz commented Jul 26, 2024

No, but you're welcome to open a PR that limits the range that this PR uses and add a new entry for versions < 15.11.1.

@chenyulun
Copy link

Are you sure vue-loader@16 doesn't support @vue/compiler-sfc@^2.7.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Yarn 2 PnP causes incorrect Typescript typings with redux-toolkit
3 participants